Replace QtKeychain with a submodule #161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit matches up with the date on which the source tree was added (Before 31 August 2021) and the most recent commit's content is already present, so I'm fairly confident this is the exact revision. This allows easier updating if required, plus it preserves history. Added a note to COMPILATION.md about cloning with submodules.
Was only able to test this locally with some modifications to the workflow so I could use act. Seems to work fine on my side. Added git-archive-all.sh to generate the archives. All of this is done on Linux, which is what I'm comfortable with.
needed this to test my workflow edit: fixed yaml syntax edit 2: can you tell I don't know yaml yet?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit matches up with the date on which the source tree was added (Before 31 August 2021) and the most recent commit's content is already present, so I'm fairly confident this is the exact revision.
This allows easier updating if required, plus it preserves history.
Added a note to
COMPILATION.mdabout cloning with submodules.Tentative github action in place to generate a source tarball on release. Also fixes the current action to use the submodules.